Skip to content

build: switch to new python meson backend#991

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
glimchb:fix-976
Apr 11, 2025
Merged

build: switch to new python meson backend#991
igaw merged 1 commit intolinux-nvme:masterfrom
glimchb:fix-976

Conversation

@glimchb
Copy link
Copy Markdown
Contributor

@glimchb glimchb commented Apr 11, 2025

Fixes #976

@glimchb
Copy link
Copy Markdown
Contributor Author

glimchb commented Apr 11, 2025

tested

 $ uvx --isolated --no-cache twine check broken-libnvme-1.12.tar.gz
Installed 27 packages in 565ms
Checking broken-libnvme-1.12.tar.gz: ERROR    InvalidDistribution: Invalid distribution metadata: unrecognized or malformed field 'description'                                              

vs

 $ uvx --isolated --no-cache twine check working-libnvme-1.12.tar.gz
Installed 27 packages in 352ms
Checking working-libnvme-1.12.tar.gz: PASSED

also ran diff on 2 packages (only metadata is different as expected):

diff -ur broken/libnvme-1.12/PKG-INFO working/libnvme-1.12/PKG-INFO
--- broken/libnvme-1.12/PKG-INFO        2025-04-11 05:19:41.365426800 +0300
+++ working/libnvme-1.12/PKG-INFO       2025-04-11 05:34:41.000000000 +0300
@@ -2,17 +2,19 @@
 Name: libnvme
 Version: 1.12
 Summary: python bindings for libnvme
-Home-page: https://github.com/linux-nvme/libnvme
-Author: Hannes Reinecke
-Author-email: [email protected]
+Keywords: nvme,storage,bindings
+Author-Email: Hannes Reinecke <[email protected]>
 License: LGPL-2.1-or-later
 Classifier: Intended Audience :: Developers
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)
 Classifier: Programming Language :: Python :: 3
 Classifier: Topic :: Software Development :: Libraries :: Python Modules
+Project-URL: Homepage, https://github.com/linux-nvme/libnvme
+Project-URL: Source, https://github.com/linux-nvme/libnvme
+Project-URL: Bug Tracker, https://github.com/linux-nvme/libnvme/issues
+Requires-Python: >=3.6
 Description-Content-Type: text/markdown
-Description:

 # libnvme

and also did upload to test pypi correctly https://test.pypi.org/project/libnvme-boris/1.13/

@glimchb glimchb marked this pull request as ready for review April 11, 2025 02:52
@glimchb glimchb mentioned this pull request Apr 11, 2025
@glimchb glimchb marked this pull request as draft April 11, 2025 05:26
@glimchb
Copy link
Copy Markdown
Contributor Author

glimchb commented Apr 11, 2025

need to check only this error

>>> import libnvme
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/glimcb/Dev/cto/libnvme/libnvme/__init__.py", line 8
    __version__ = @PROJECT_VERSION@
                  ^
SyntaxError: invalid syntax

@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Apr 11, 2025

I wanted to do a release today. Do you think you get this sorted out in the next couple of hours? If not, it's not a real blocker. Maybe we can figure out to upload it afterwards somehow. Surely, we are not the first having this type of problems, where the release is just fine but the upload to PyPi doesn't work.

@glimchb
Copy link
Copy Markdown
Contributor Author

glimchb commented Apr 11, 2025

@igaw all fixed now. was too late in the night, so didn't test properly....

uv pip install --no-cache libnvme/dist/libnvme-1.12-cp312-cp312-linux_x86_64.whl

and

Python 3.12.8 (main, Jan 14 2025, 22:49:14) [Clang 19.1.6 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import libnvme
>>> libnvme.__version__
'1.12'
>>>

good to merge imho

@glimchb glimchb marked this pull request as ready for review April 11, 2025 12:23
@igaw igaw merged commit 4c18921 into linux-nvme:master Apr 11, 2025
12 checks passed
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Apr 11, 2025

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python upload fails

2 participants